Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EIP-4803 #3827

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Implement EIP-4803 #3827

wants to merge 2 commits into from

Conversation

jochem-brouwer
Copy link
Member

Closes #3825

@jochem-brouwer jochem-brouwer added PR state: WIP package: tx type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR. labels Dec 22, 2024
@jochem-brouwer
Copy link
Member Author

Running all hardforks because I think ethereum/tests might not have implemented this (and instead checked original limit of 2^64-1)

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.53%. Comparing base (3f0f3b5) to head (1b43fc1).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.23% <ø> (ø)
client 73.70% <ø> (ø)
common 89.82% <ø> (ø)
devp2p 71.95% <ø> (ø)
evm 64.60% <ø> (ø)
genesis 100.00% <ø> (ø)
mpt 52.09% <ø> (ø)
rlp 95.11% <ø> (ø)
statemanager 67.76% <ø> (ø)
tx ?
util 72.81% <ø> (ø)
vm 57.02% <ø> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer
Copy link
Member Author

Ok, this is not supported by ethereum/tests but rather in the TransactionTests, see:

https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/12450447293/job/34757292887?pr=3827

Errors for instance:

     → RLP is valid, but decoding failed
   × TransactionWithHighGasLimit64Minus1 > TransactionWithHighGasLimit64Minus1 [shanghai]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: tx PR state: WIP type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement EIP-4803
1 participant